[css-fonts-4] Give clearer advice to authors about font-feature-settings and font-variation-settings #7815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs and font-variation-settings This patch does a few things: 1. Fixes a small handful of whitespace / typo problems 2. Adds an example showing how the font-weight descriptor can accept a range 3. Advises authors to use high-level font-variant properties instead of font-feature-settings 4. Rewrites an example to follow the above advice 5. Advises authors to use high-level font properties instead of font-variation-settings
|
Great addition, thanks for the clear examples! (Super nitty nitpick, if best practices are to be used in the examples, make the WOFF font a WOFF2 font?) |
litherum
commented
Oct 1, 2022
svgeesus
reviewed
Oct 3, 2022
RoelN
reviewed
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does a few things:
This patch isn't quite ready to land; there's a problem where a
<ol>and a<table>inside a<p class="advisement">do not actually end up in the advisement box in the rendered content. @tabatkins do you know how to fix this?cc (@PeterConstable) via https://twitter.com/pgconstable/status/1575526680076357633